search

AhmedShaiyan / pe

0 stars 0 forks source link

Inconsistency in command spacing error handling. #3

Open AhmedShaiyan opened 3 months ago

AhmedShaiyan commented 3 months ago

Sometimes when no space is used between commands, it works, example:

no gap between add/ and d/

image.png

but sometimes it gives an error: no gap between d/ and amt/

image.png

soc-pe-bot commented 3 months ago

Team's Response

image.png

As per the user guide, users are reminded to have a space after each input segment to ensure proper functionalities. The lack of space may cause the program to behave unexpectedly. "Unexpected" means that the program may work as intended when spaces are not included in some parts of the input command. However, users should heed the advice in the UG and include spaces at all times.

the app is behaving as expected. image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error handling for spaces between commands is not specific

entering a valid expense tracker command but forgetting a spaces gives "unknown command". Could be more specific.

example: input without space between e/ and add/

image.png

[original: nus-cs2113-AY2324S2/pe-interim#1627] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As per the UG, warning for input format has been clearly highlighted in BOLD and RED for the user to ensure spaces are used. omitting it is a user error which have been highlighted to the user, hence not a bug in the error message image.png

image.png

This is an invalid command and behaves as expected image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I believe one report is referring to the fact that the error messages are not clear about the exact error, and the other one is about the differing outputs for the essentially the same error ( no space between commands add/ and d/ and no space between commands d/ and amt/ give two different outputs, one is accepted while one is stated as invalid

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]