search

AhmedShaiyan / pe

0 stars 0 forks source link

Empty commands give vague error messages #5

Open AhmedShaiyan opened 3 months ago

AhmedShaiyan commented 3 months ago

Error messages can be more specific if a input is empty:

Example:

description of expense is empty gives invalid input but does not mention exact error:

image.png

nus-se-bot commented 3 months ago

Team's Response

We would request this as a severity-type low issue as it does not affect normal operations. It is an error message mismatch and therefore it is a functionality bug.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error handling for spaces between commands is not specific

entering a valid expense tracker command but forgetting a spaces gives "unknown command". Could be more specific.

example: input without space between e/ and add/

image.png

[original: nus-cs2113-AY2324S2/pe-interim#1627] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As per the UG, warning for input format has been clearly highlighted in BOLD and RED for the user to ensure spaces are used. omitting it is a user error which have been highlighted to the user, hence not a bug in the error message image.png

image.png

This is an invalid command and behaves as expected image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The bug reports are for two seperate errors, one is for having no space between commands while the other is for missing an input entirely:

image.png

vs

image.png

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Not specifying the error to the user counts as a feature flaw: ![image.png](https://raw.githubusercontent.com/AhmedShaiyan/pe/main/files/522925ce-91c1-46ea-9730-8cbdbc17eae6.png) when an input is missing, such as a missing description (as per the example given above), the error message can be more specific so the user can know immediately what is wrong with their input. Currently, when the description is missing, this is the given error: ![image.png](https://raw.githubusercontent.com/AhmedShaiyan/pe/main/files/7e9bc620-0c83-456e-956c-f6563717dd21.png) Perhaps a more helpful error message might be "Description is missing" or "Invalid description".
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I believe such a bug can lead to the user having to tediously look through their inputs quite frequently, fitting the description of a medium severity bug. And it definitely isnt just a cosmetic issue.