AhmedYahya24 / spzceX

0 stars 1 forks source link

Dates are not valid identifiers #15

Open NouraldinS opened 2 years ago

NouraldinS commented 2 years ago

https://github.com/AhmedYahya24/spzceX/blob/d753e7f6e31fa36501ca331d113bc0521a555a4d/space-x-graphql/src/utils/hooks/useQueryModal.js#L8-L12

Usage of date as a unique identifier is incorrect, even if in every case it returned a unique result. The correct way to fetch a launch is via the launch api:

{
  launch(id: "96") {
    id
    rocket {
        rocket {
          cost_per_launch
          mass {
            kg
            lb
          }
          diameter {
            feet
            meters
          }
          success_rate_pct
        }
      }
  }
}
HamzAlaydi commented 2 years ago

في مشكلة ف الapi بقدرس اعمل filter على ال id

NouraldinS commented 2 years ago

@HamzAlaydi image