Bugfix for certain windows crashing wayfire on opening.

AhoyISki / Firedecor

An advanced window decoration plugin for the wayfire window manager.

71 stars 7 forks source link

Bugfix for certain windows crashing wayfire on opening. #9

Closed FuzzyQuils closed 2 years ago

FuzzyQuils commented 2 years ago

Sorry for sounding rude if I do, but is there a reason this specific line is adding 1 to the end of the substring length?

By removing the +1, this fixes Steam, the Unity Editor and Wayfire Configuration Manager crashing the entire session with a SIGABRT upon their respective windows being spawned.

Tested by modifying the Arch Linux PKGBUILD and recompiling with this change in there.

AhoyISki commented 2 years ago

Oh yeah, now that I look at it, that line of code makes no sense. But I guess I haven't experienced these bugs considering my firedecor_icons file is already well populated.

AhoyISki commented 2 years ago

I guess at the time I was counting from 1 instead of 0? Don't really know why I did that.

FuzzyQuils commented 2 years ago

I guess at the time I was counting from 1 instead of 0? Dont6really know why I did that.

haha happens to the best of us, I'm often running into that sort of thing myself in my game engine codebase. xD