search

Ahryman40k / typescript-fhir-types

Typescript / Javascript object model for FHIR standard
MIT License
126 stars 27 forks source link

Questionnaire_EnableWhenOperatorKind doesn't match FHIR R4 spec #20

Closed JWess closed 4 years ago

JWess commented 4 years ago

The type Questionnaire_EnableWhenOperatorKind uses words ("Equal", "Greater", ...) instead of symbols ("=", ">").

See the spec here: https://www.hl7.org/fhir/questionnaire-definitions.html#Questionnaire.item.enableWhen.operator

Ahryman40k commented 4 years ago

Hi Joel,

Thank you for your contribution and your PR. I try to remember if words instead of logical operators were intended or not. I just check that point first before merging your PR. Have you made some tests to ensure a JSON will be successfully checked ? and an object using this enum generates a valid JSON ? It exists a lot of tests in the library but this enum may not be checked in any of them.

JWess commented 4 years ago

Hi Joel,

Thank you for your contribution and your PR. I try to remember if words instead of logical operators were intended or not. I just check that point first before merging your PR. Have you made some tests to ensure a JSON will be successfully checked ? and an object using this enum generates a valid JSON ? It exists a lot of tests in the library but this enum may not be checked in any of them.

Thanks for merging. Sorry, I did not update any tests.