Closed twonamejames closed 3 years ago
Merging #26 into 4.0.0 will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 4.0.0 #26 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 684 684
Lines 10425 10425
Branches 301 301
=======================================
Hits 10280 10280
Misses 144 144
Partials 1 1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9546bc7...7f4d487. Read the comment docs.
Hi @twonamejames, Thank you for the update. Indeed it was a job I need to do. I agree with everything except the library version., It will be nice if it can stay on version 4. All your changes doesn't break FHIR objects so it's still R4. I did myself a mistake with FHIR version and I'm waiting next release to fix it. Indeed, my lib should have been in version 4.0.0.x then in version 4.0.1.x but I missed a '0'. Can you just increase the patch number ?
Thank for you contribution and your time :)
Thank you very much for this !
This change upgrades the versions of io-ts and fp-ts to version 2. This is to fix type errors caused by incompatible versions of fp-ts and io-ts in a project I'm working on that has dependencies on version 2 of both packages as well as this package.
I also took the opportunity to update any outdated packages that could be updated without breaking.
Luckily only a few things broke when upgrading io-ts to version 2. I only fixed errors reported by tsc. I don't know if other issues still exist, but all the tests seem to be passing.
Because I believe this is a breaking change, I bumped the major version of this package as well.