Ahryman40k / typescript-fhir-types

Typescript / Javascript object model for FHIR standard
MIT License
126 stars 27 forks source link

Why are the enum entries prefixed with underscores ? #33

Closed fungiboletus closed 3 years ago

fungiboletus commented 3 years ago

Hi,

Thanks for your work on this library. It saves me quite some time.

I wonder why in the enums every entry is prefixed with an underscore, as I'm tempted to remove them.

export declare enum CarePlan_DetailStatusKind {
    _notStarted = "not-started",
    _scheduled = "scheduled",
    _inProgress = "in-progress",
    _onHold = "on-hold",
    _completed = "completed",
    _cancelled = "cancelled",
    _stopped = "stopped",
    _unknown = "unknown",
    _enteredInError = "entered-in-error"
}
Ahryman40k commented 3 years ago

Hi Antoine,

I can't remember exactly why I used underscore, but I remember about naming issues ...

You may try to remove them.

Take care, Ahry

Le lun. 5 avr. 2021, à 01 h 35, Antoine Pultier @.***> a écrit :

Hi,

Thanks for your work on this library. It saves me quite some time.

I wonder why in the enums every entry is prefixed with an underscore, as I'm tempted to remove them.

export declare enum CarePlan_DetailStatusKind { _notStarted = "not-started", _scheduled = "scheduled", _inProgress = "in-progress", _onHold = "on-hold", _completed = "completed", _cancelled = "cancelled", _stopped = "stopped", _unknown = "unknown", _enteredInError = "entered-in-error"}

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ahryman40k/typescript-fhir-types/issues/33, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSIXTOR7D6V4MHOWQBPEV3THFDZDANCNFSM42MHMKJA .

Ahryman40k commented 3 years ago

no activity