search

AhsanAyaz / ngx-device-detector

An Angular v7+ library to detect the device, OS, and browser details.
https://ahsanayaz.github.io/ngx-device-detector
MIT License
520 stars 101 forks source link

Not Working in Angular 9 #147

Closed coderavel closed 4 years ago

coderavel commented 4 years ago

image

AhsanAyaz commented 4 years ago

Hey @coderavel. The library is not compatible with IVY at the moment. But it's in the plans. I'll keep you posted.

BruneXX commented 4 years ago

Hi @coderavel what is your compiler configuration to get that error?

a-mesin commented 4 years ago

Any news on this? This is keeping us from updating to Angular 9.

theCrius commented 4 years ago

@BruneXX with a default angular 9 angular.json, I get that error as well when running ng serve

image

In this list is shown all the changes that can make a library not compatible: https://angular.io/guide/ivy-compatibility

theCrius commented 4 years ago

I'm trying to update it to angular9 but it seems that this library has not been built using the classic angular-cli which makes things quite more complicated in terms of upgrading. Am i mistaken? @AhsanAyaz are you still working on this? Any pointer you can give?

Ah I see, it's been built with Yeoman. Good luck with that.

AhsanAyaz commented 4 years ago

@coderavel , @theCrius. There shouldn't be any issue working with Angular 9.x or Angular 10.x now. The library has been updated to be built on top of Angular CLI. 🙂 @Please try the latest release and re-open the issue if it persists.