Closed elementalTIMING closed 4 years ago
Same problem!
Confirm! Same problem, downgrade to 1.4.6!
Same problem. Downgrade to 1.4.6
Confirmed, same problem.
I came here to report this issue, now I can only confirm it, too ;-)
Confirmed, same problem.
same problem :(
Same problem
same problem
I submitted this Pull Request that fixed it for me.
@AhsanAyaz - I would kindly suggest that you re-version this update to 2.0. Such a major, breaking change really shouldn't be part of a minor release. Most users wouldn't expect an update from 1.46 to 1.5 to include breaking changes, if you're going by the rules of semantic versioning (which is highly encouraged): https://semver.org/
Given a version number MAJOR.MINOR.PATCH, increment the:
- MAJOR version when you make incompatible API changes,
- MINOR version when you add functionality in a backwards compatible manner, and
- PATCH version when you make backwards compatible bug fixes.
@AhsanAyaz - I would kindly suggest that you re-version this update to 2.0. Such a major, breaking change really shouldn't be part of a minor release. Most users wouldn't expect an update from 1.46 to 1.5 to include breaking changes, if you're going by the rules of semantic versioning (which is highly encouraged): https://semver.org/
Given a version number MAJOR.MINOR.PATCH, increment the:
- MAJOR version when you make incompatible API changes,
- MINOR version when you add functionality in a backwards compatible manner, and
- PATCH version when you make backwards compatible bug fixes.
I would agree. It appears the DeviceDetectorModule
was removed from the library, so I had to make changes in my implementation of the package for it to work after applying my changes to fix the library exports.
Hey folks, thanks for chiming in :) I can fix the versioning and will publish a new one.
@elementalPRESS, @drewpayment, @marlonbaskin, @edwincabrejos, @air-Design, @veenagadag, @MoxxiManagarm , @quosol , @ksrebrev , @ochikov , @madviral , @Ruslancic. The issue has been fixed with the latest release 1.5.2. Please upgrade your dependencies. 🙂 Also, thanks for being awesome. 🎉
Will now release the 2.0.0 without the DeviceDetectorModule. Closing the issue. Feel free to re-open if it persists 🙂
@AhsanAyaz I think that you still need to make the change made in @drewpayment's pull request (#164 ) in the v2.0.0 release.
Same problem. Downgrade to 1.4.6
@AhsanAyaz Can you please let us know how can we make things work in version2.0.5 of the library which does not include DeviceDetectorModule ? An example using Angular 9+ would be really helpful. Thanks.
@DSRM
For me it was enough to remove import {DeviceDetectorModule} from 'ngx-device-detector';
and DeviceDetectorModule.forRoot()
from app.module.ts
after an update.
@DSRM , yes, please do as @HaraldStiwa has suggested :)
After update:
`"export 'DeviceDetectorModule' was not found in 'ngx-device-detector'