AhsanAyaz / ngx-device-detector

An Angular v7+ library to detect the device, OS, and browser details.
https://ahsanayaz.github.io/ngx-device-detector
MIT License
520 stars 101 forks source link

Error after update #162

Closed elementalTIMING closed 4 years ago

elementalTIMING commented 4 years ago

After update:

`"export 'DeviceDetectorModule' was not found in 'ngx-device-detector'

ERROR in src/app/core/core.module.ts:15:10 - error TS2305: Module '"../../../node_modules/ngx-device-detector/ngx-device-detector"' has no exported member 'DeviceDetectorModule'.

15 import { DeviceDetectorModule } from 'ngx-device-detector';`
madviral commented 4 years ago

Same problem!

Ruslancic commented 4 years ago

Confirm! Same problem, downgrade to 1.4.6!

ochikov commented 4 years ago

Same problem. Downgrade to 1.4.6

ksrebrev commented 4 years ago

Confirmed, same problem.

MoxxiManagarm commented 4 years ago

I came here to report this issue, now I can only confirm it, too ;-)

quosol commented 4 years ago

Confirmed, same problem.

veenagadag commented 4 years ago

same problem :(

aiira-co commented 4 years ago

Same problem

edwincabrejos commented 4 years ago

same problem

drewpayment commented 4 years ago

I submitted this Pull Request that fixed it for me.

marlonbaskin commented 4 years ago

@AhsanAyaz - I would kindly suggest that you re-version this update to 2.0. Such a major, breaking change really shouldn't be part of a minor release. Most users wouldn't expect an update from 1.46 to 1.5 to include breaking changes, if you're going by the rules of semantic versioning (which is highly encouraged): https://semver.org/

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes,
  2. MINOR version when you add functionality in a backwards compatible manner, and
  3. PATCH version when you make backwards compatible bug fixes.
drewpayment commented 4 years ago

@AhsanAyaz - I would kindly suggest that you re-version this update to 2.0. Such a major, breaking change really shouldn't be part of a minor release. Most users wouldn't expect an update from 1.46 to 1.5 to include breaking changes, if you're going by the rules of semantic versioning (which is highly encouraged): https://semver.org/

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes,
  2. MINOR version when you add functionality in a backwards compatible manner, and
  3. PATCH version when you make backwards compatible bug fixes.

I would agree. It appears the DeviceDetectorModule was removed from the library, so I had to make changes in my implementation of the package for it to work after applying my changes to fix the library exports.

AhsanAyaz commented 4 years ago

Hey folks, thanks for chiming in :) I can fix the versioning and will publish a new one.

AhsanAyaz commented 4 years ago

@elementalPRESS, @drewpayment, @marlonbaskin, @edwincabrejos, @air-Design, @veenagadag, @MoxxiManagarm , @quosol , @ksrebrev , @ochikov , @madviral , @Ruslancic. The issue has been fixed with the latest release 1.5.2. Please upgrade your dependencies. 🙂 Also, thanks for being awesome. 🎉

Will now release the 2.0.0 without the DeviceDetectorModule. Closing the issue. Feel free to re-open if it persists 🙂

JaxonWright commented 4 years ago

@AhsanAyaz I think that you still need to make the change made in @drewpayment's pull request (#164 ) in the v2.0.0 release.

catalin-matei commented 4 years ago

Same problem. Downgrade to 1.4.6

DSRM commented 3 years ago

@AhsanAyaz Can you please let us know how can we make things work in version2.0.5 of the library which does not include DeviceDetectorModule ? An example using Angular 9+ would be really helpful. Thanks.

ghost commented 3 years ago

@DSRM For me it was enough to remove import {DeviceDetectorModule} from 'ngx-device-detector'; and DeviceDetectorModule.forRoot() from app.module.ts after an update.

AhsanAyaz commented 3 years ago

@DSRM , yes, please do as @HaraldStiwa has suggested :)