AhsanAyaz / ngx-device-detector

An Angular v7+ library to detect the device, OS, and browser details.
https://ahsanayaz.github.io/ngx-device-detector
MIT License
520 stars 101 forks source link

Tablet Issue #191

Closed BibiSebi closed 3 years ago

BibiSebi commented 3 years ago

Hello, I have discovered an issue where tablets are not recognised as tablets. Here are the user agents -> #180

"Mozilla/5.0 (Linux; Android 9; SM-T865) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.106 Safari/537.36"

&

"Mozilla/5.0 (Linux; Android 9; Lenovo TB-X606F Build/PPR1.180610.011;wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/86.0.4240.185 Safari/537.36"

@biswas123

mariomazon commented 3 years ago

Hi. Samsung s6 tab lite also recognizes as mobile, instead of tablet !

see user agent: Mozilla/5.0 (Linux; Android 10; SM-P615) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.93 Safari/537.36

olga-aptekar commented 3 years ago

Hi! I have the same issue. Device: Samsung TAB A7. User agent: Mozilla/5.0 (Linux; Android 10; SM-T500) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.105 Safari/537.36.

As I see, 'SM-T500' is absent in the tablets' list here: https://koderlabs.github.io/ngx-device-detector/miscellaneous/variables.html#TABLETS_RE. Could you please update the devices' lists?

Could you please clarify, do you update the devices' lists with modern devices regularly and how often? Thanks in advance.

olga-aptekar commented 3 years ago

194

AhsanAyaz commented 3 years ago

Hi @olga-aptekar. We don't update the devices regularly due to time constraints. However, we should be adding the devices anyone reports as soon as possible. And I've been pretty bad at that lately due to some commitments. Since this is a community project, I was hoping for PRs 🙂 . I will however add all the user strings as soon as possible and will create a release soon.

AhsanAyaz commented 3 years ago

@olga-aptekar @mariomazon @Sebi2909 Released with https://github.com/KoderLabs/ngx-device-detector/releases/tag/v2.0.7