AhsanAyaz / ngx-device-detector

An Angular v7+ library to detect the device, OS, and browser details.
https://ahsanayaz.github.io/ngx-device-detector
MIT License
515 stars 102 forks source link

Add Angular 12 support #216

Closed eesquibel closed 3 years ago

eesquibel commented 3 years ago

Angular 12 has just come out and it would be nice to see support for it added to ngx-device-detector.

Right now adding it to a clean Angular 12 site results in the following error:

# ng new --routing --style scss angular12 # cd angular12 # npm install --save ngx-device-detector

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: angular12@0.0.0 npm ERR! Found: @angular/common@12.0.0 npm ERR! node_modules/@angular/common npm ERR! @angular/common@"~12.0.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@">=7.0.0 <9.0.0 || ^9.0.0-0 ||^10.0.11 ||^11.0.0" from ngx-device-detector@2.0.10 npm ERR! node_modules/ngx-device-detector npm ERR! ngx-device-detector@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See C:\Users\eric\AppData\Local\npm-cache\eresolve-report.txt for a full report. npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\eric\AppData\Local\npm-cache_logs\2021-05-13T16_56_05_872Z-debug.log

AhsanAyaz commented 3 years ago

Closed by #217