AhsanAyaz / ngx-device-detector

An Angular v7+ library to detect the device, OS, and browser details.
https://ahsanayaz.github.io/ngx-device-detector
MIT License
517 stars 101 forks source link

chore: update to Angular 15 #260

Closed Yberion closed 1 year ago

Yberion commented 1 year ago

Hello,

This PR does:

Feel free to also remove other PR/branche related to packages update for cleaning purpose.

If everything is ok, I can make a new commit to bump the version. Could you release a new version following this PR? (This would be much appreciated heh)

Have a good day.

cc @AhsanAyaz

hoi4 commented 1 year ago

Would be awesome to have this released 😇

rybos86 commented 1 year ago

Any news on the release date?

MessiasLima commented 1 year ago

@rafayali @jawaidgadiwala @riazraza any update on this?

shobaiye commented 1 year ago

Any update on this? When will this be released?

MNorgren commented 1 year ago

@Jorciney, @Yberion @rafayali - Any updates on this?

Yberion commented 1 year ago

Hello @MNorgren, sorry I'm not maintainer, I can't release a new version ^^

Nickolaus commented 1 year ago

@Yberion could you be so nice to rebase this one to the current state so a maintainer has the ability to merge this? This would at least increase the chance that this will merged soon

Yberion commented 1 year ago

@Yberion could you be so nice to rebase this one to the current state so a maintainer has the ability to merge this? This would at least increase the chance that this will merged soon

The problem with that is, I updated the repo to use the latest version of mostly all deps. The problem is that, some Dependabot package update were merged, but it was already done on this ticket so there's some conflicts. I will take a look tonight.

ivineettiwari commented 1 year ago

@Yberion Can you please update on this, I am in the process to upgrade my angular app to the new version.

Yberion commented 1 year ago

@Yberion Can you please update on this, I am in the process to upgrade my angular app to the new version.

Hello, I've rebased the branche to master, no more conflict for merging. Like I said, I'm not a maintainer of this project so it's not on my side to release an official version of this lib.

ivineettiwari commented 1 year ago

@rafayali @jawaidgadiwala @riazraza Can you please review and approve the merge request and release the new version?

ivineettiwari commented 1 year ago

@Yberion Can you please update on this, I am in the process to upgrade my angular app to the new version.

Hello, I've rebased the branche to master, no more conflict for merging. Like I said, I'm not a maintainer of this project so it's not on my side to release an official version of this lib.

Thanks @Yberion , for your quick action

ivineettiwari commented 1 year ago

@jawaidgadiwala The merge has failed in master branch. Can you please fix that and release the new version