AhsanAyaz / ngx-device-detector

An Angular v7+ library to detect the device, OS, and browser details.

https://ahsanayaz.github.io/ngx-device-detector

MIT License

517 stars 101 forks source link

#269 Brave Browser Detection #270

Open MattSenter opened 1 year ago

MattSenter commented 1 year ago

Problem

There is no detection for Brave Browser in this library.

Solution

Add userAgentData inspection to detect Brave Browser. Note that userAgentData can also be used to detect Chrome over the legacy userAgent string.

AhsanAyaz commented 1 year ago

@MattSenter this is awesome work! Could you check the lint errors and push again? I can review and merge asap then 🙂

MattSenter commented 1 year ago

@AhsanAyaz Updated! Sorry it took so long.

MattSenter commented 1 year ago

@AhsanAyaz fixed conflicts

MattSenter commented 1 year ago

@AhsanAyaz I think the workflow might be busted. I'm not seeing a linting or testing issue on my end.