Closed pvds closed 9 months ago
@AhsanAyaz should I manually bump the version, changelog and readme?
Update: I'll do the same as you did in the NG16 PR
When can this be merged and released? This package is blocking me from migrating to v17 normally right now.
@pvds thanks a lot for doing the work on this.
@isoroka-plana the latest released package version works fine so until version 7 is released you could specify an override in your package.json to temporarily resolve the peer dependency mismatch.
For example for npm:
"overrides": {
"ngx-device-detector": {
"@angular/common": "$@angular/common",
"@angular/core": "$@angular/core",
}
}
@isoroka-plana the latest released package version works fine so until version 7 is released you could specify an override in your package.json to temporarily resolve the peer dependency mismatch.
For example for npm:
"overrides": { "nxg-device-detector": { "@angular/common": "$@angular/common", "@angular/core": "$@angular/core", } }
thank you for this suggestion, I didn't know that overrides exist, but I tried and unfortunately it doesn't work in an npm workspace, as overrides can only be used in the root package.json. Starting to think that my best option is just to copy the service for now.
@pvds Override is not working for me either
edit: Ah okay, you mistyped "ngx" as "nxg". with the correct name it works @isoroka-plana
I also realized a few hours later that there was a typo 🤣 But still I had to move the related packages to the root of the monorepo to be able to use overrides.
Damn! What's going on here 😄 Sorry I was busy trying to wrap up the Angular Cookbook 2nd Edition so I can sleep in peace. I will look into this ASAP. Thanks for the work @isoroka-plana and @pvds
@AhsanAyaz thank you for merging it! Credit is all @pvds's, I am merely a passerby.
Make the ngx-device-detector library and demo app compatible with Angular 17
Fixes #282