search

Ahsankhalid618 / react-weather-app

The weather app project is a dynamic and user-friendly web application that uses React.js to retrieve current and 5-day weather forecasts for various cities around the world. The app allows users to search for a city by name and view its weather conditions, including temperature, humidity, wind speed, and description of the current weather.
https://react-weather-app101.netlify.app/
22 stars 20 forks source link

Added 24hour graph #38

Open relaxgameing opened 1 month ago

relaxgameing commented 1 month ago

related: #27

i have created a graph to show the next 24hours temperature of a location

@Ahsankhalid618 here is a video of the working of graph: https://github.com/user-attachments/assets/54e1bc65-44e0-453d-9014-8c2f234e6c17

note:

i have also refactored the codebase because the Maindata.jsx file was containing the whole jsx logic so it was to cluttered so i have separated it into different components there might be some file which are changed just because i use 4 tab width so if you need me to change back to 2 space tab then i will do that

netlify[bot] commented 1 month ago

Deploy request for react-weather-app101 pending review.

Visit the deploys page to approve it

Name Link
Latest commit fc17f758d1adf028882c328a36501c024af46053
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-weather-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 1:17pm
Ahsankhalid618 commented 1 month ago

@relaxgaming good work, but enhance the UI of the graph a bit more, it looks too simple for merging in production.

relaxgameing commented 1 month ago

@relaxgaming good work, but enhance the UI of the graph a bit more, it looks too simple for merging in production.

@Ahsankhalid618 what kind of enhancement ? Can you provide a little more details of what changes you need in the graph

Ahsankhalid618 commented 1 month ago

@relaxgaming good work, but enhance the UI of the graph a bit more, it looks too simple for merging in production.

@Ahsankhalid618 what kind of enhancement ? Can you provide a little more details of what changes you need in the graph

I am talking about the UI of the graph you implemented, its too simple, just a line, use any UI library if you want to, or explore UI inspirations on google to find out the graph presentation for weather, etc. I hope you understand, let me know if you have any questions.

relaxgameing commented 4 weeks ago

@Ahsankhalid618 I have tried changing the graph ui but i am not able to enhance the ui as ui design is not my strong part so now it either you can provide a sample of the ui which you desire or merge it as it is

Ahsankhalid618 commented 4 weeks ago

I am asking like that, not exactly but you can take inspiration from this. image