Ai-Thinker-Open / ESP32-A1S-AudioKit

Ai-Thinker AudioKit Board SDK - 安信可 esp32-a1s 音频模组开发板
Other
132 stars 63 forks source link

Documentation errors #40

Open msalat opened 1 year ago

msalat commented 1 year ago
  1. some links have a backslash in their paths

  2. Section "For ESP-A1s (ESP32 + AC101 audio chips)"

es8388 instead of ac101:

and later laster , add the below code to edit the CMake file : components/audio_hal/CMakeLists.txt

./driver/es8388 ./driver/es8388/es8388.c

and an image is missing/wrong syntax: ![](static/add_ac101_cmake files.png)

msalat commented 1 year ago

... and I had to remove all non-ac101 (es8388, ..) lines from components/audio_hal/CMakeLists.txt because of errors like

esp-adf/components/audio_hal/driver/es8311/es8311.c:59:22: error: 'BOARD_PA_GAIN' undeclared (first use in this function)
msalat commented 1 year ago

ok https://github.com/Ai-Thinker-Open/ESP32-A1S-AudioKit/issues/38#issuecomment-1483840692 instead is enough, no need to remove non-ac101 from CMakeLists.txt

msalat commented 1 year ago

https://github.com/Ai-Thinker-Open/ESP32-A1S-AudioKit/blob/master/static/add_ac101_cmake%20files.png does contain es8388 instead of ac101, too