AiTechEye / xaenvironment

10 stars 4 forks source link

Main inventory page issues #12

Closed MrRar closed 1 year ago

MrRar commented 1 year ago

Here is a list of issues I have found with the main inventory page:

I also have an additional question. What is the inventory slot to the top right of the craft grid?

If the author of this game is agreeable to the idea, I will try making a PR to fix these issues.

AiTechEye commented 1 year ago

thanks for your opinions :) ... done already

MrRar commented 1 year ago

Thanks for the update! It is much better now!

https://github.com/AiTechEye/xaenvironment/tree/master/mods/commands/textures better?

Yes! These icons I can understand.

I have some recommendations for moving stuff around: Capture

I think the hat slot should be near the player model. (It would be cool to implement skins as items and also have a slot for that). Maybe scoot the player over to make room for stuff. The clear inventory button should be right next to the inventory somewhere.

It would be nice to have an arrow between the craft grid and the output to make it clear where the output goes.

I still want to work on this BTW if you don't mind.

Checkout my inventory search PR when you get a chance: #11

AiTechEye commented 1 year ago

screenshot_20221109_113230

i organized some of them, i see no reason to move the rest, when you are inside a map the map button apears, so it need space too.

i dont think there is a point of have slots for skins cuz we already have a "shop" for that. but i could make skins as treasures, maybe drops from mobs? then you just eat them like the coins.

Im unsure about the coins amount, cuz usually we have to go to the store or look at a trader node to see it, so i included it in the inv instead, but there is no really space for that.

i tried to add them to the left top, but couldn't shrink the backpack buttons more to get that space, what do you think?

MrRar commented 1 year ago

It's definitely a bit better now.

i tried to add them to the left top, but couldn't shrink the backpack buttons more to get that space, what do you think?

I think it could fit better if you move the player mesh down. There should also be some context about what the yellow number represents. It should say for example, "676 coins"

AiTechEye commented 1 year ago

changed / i put a tooltip on the amount otherwise it looks weird

MrRar commented 1 year ago

changed / i put a tooltip on the amount otherwise it looks weird

I still think displaying units is best but a tooltip is better than nothing.