AiTechEye / xaenvironment

10 stars 4 forks source link

quads mod crash #25

Closed MoNTE48 closed 12 months ago

MoNTE48 commented 1 year ago
2023-08-13 00:54:22: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'quads' in callback luaentity_Step(): .../bin/../games/xaenvironment/mods/quads/car.lua:296: attempt to index local 'key' (a string value)
2023-08-13 00:54:22: ERROR[Main]: stack traceback:
2023-08-13 00:54:22: ERROR[Main]:   .../bin/../games/xaenvironment/mods/quads/car.lua:296: in function <.../bin/../games/xaenvironment/mods/quads/car.lua:266>
MrRar commented 1 year ago

Are any particular steps required to reproduce this crash? Or is it just a one off.

MoNTE48 commented 1 year ago

If the player is offline get_player_control returns an empty string in Minetest before 5.6.

MrRar commented 1 year ago

If the player is offline get_player_control returns an empty string in Minetest before 5.6.

That doesn't seem to be the case according to my testing. In MT 5.5 PlayerObjectRef:get_player_control() returns an empty table for a logged out player and there's no crash.

It is true for MT 5.4 but there is a lot of things in XaEnvironment that are incompatible with MT 5.4. Not sure MT 5.4 is worth it at this point.