search

Aida-Enna / XIVPlugins

A collection of plugins for Final Fantasy XIV
31 stars 4 forks source link

[Portrait Fixer] Gear Set List Returns to Default Position #25

Closed sleeds2 closed 2 months ago

sleeds2 commented 2 months ago

When I update a gear set and the portrait is automatically updated, the next time I open the Gear Set List it has returned to the default position on the right side of the screen instead of where I have previously dragged it. This only seems to happen if I have closed the Gear Set List window before clicking the button to update the set.

Screenshot 2024-07-14 232151

Screenshot 2024-07-14 232306

Aida-Enna commented 2 months ago

Isn't this how the game usually handles it? I just tested ingame (with both the plugin enabled and disabled) - if I:

1) Open the character menu 2) Open the gearset menu 3) Move the gearset menu 4) Close the gearset menu and character menu (or close just the character menu, which closes both of them)

when I open the character and then gearset menu again, it's right aligned next to the character window.

sleeds2 commented 2 months ago

Sorry I'm realizing "Default Position" is wrong here.

If I follow your steps it works, but if I follow these steps the Gear Set Menu ends up way at the right edge of the screen.

  1. Open the character menu
  2. Change your gear
  3. Hit the "Update Gear Set" button while the gearset window is closed.
  4. The next time you open the gear set menu it is all the way on the right side of the screen, as seen in my second screenshot.
  5. Close the character menu and re-open it and it will be back to the default.

I can only reproduce this if the plugin is enabled and the gearset menu is closed at the time of updating the gearset. It is definitely not a big deal since re-opening the list fixes it, but figured I would let you know!

Aida-Enna commented 2 months ago

Oooh, I see it. Thanks for letting me know, I'll look into it (and I think you also accidentally made me aware of another bug!)

Aida-Enna commented 2 months ago

The fix for this should be live soon, can you double check to make sure it fixed this and let me know? Thanks!

sleeds2 commented 2 months ago

Looks great, thanks for the quick fix!

Aida-Enna commented 1 month ago

Unfortunately, after some more testing, it looks like fixing that bug introduced other issues that could prevent the plugin from saving at all and had to be reverted. I'll keep looking into it and seeing if I can fix it down the line as my understanding of the internals grows, but for now I think we'll have to live with it. Sorry!