Aida-Enna / XIVPlugins

A collection of plugins for Final Fantasy XIV
31 stars 4 forks source link

AutoLogin prevents changing data centers if no character is available on main datacenter. #34

Closed athuy closed 1 week ago

athuy commented 2 weeks ago

Sometimes I forget to return to my original datacenter before exiting the game. When booting FFXIV in this state, auto login will attempt to login to a character that is not currently on the datacenter. The plugin also prevents manually changing datacenters when this happens and requires a relaunch of FFXIV with plugins disabled and returning to the original datacenter to resolve.

Aida-Enna commented 2 weeks ago

Unfortunately, I can't do anything about the first issue because we have no way to keep track of characters and make sure they're where they're supposed to be. Sorry! As for the latter issue (not being able to change DCs), I'll take a look at it when I get a chance and see if I can replicate and then work around it.

xKiisa commented 2 weeks ago

Previously Autologin allowed to cancel the auto login by holding CTRL on startup, this would at least stop the login process and allow manual switching to another DC. Is there a reason this doesn't work anymore? Also maybe it's possible to implement a check if the login fails (since the game continuously throws an error message) and cancel the auto login so it doesn't keep trying to login?

Aida-Enna commented 2 weeks ago

Previously Autologin allowed to cancel the auto login by holding CTRL on startup, this would at least stop the login process and allow manual switching to another DC. Is there a reason this doesn't work anymore?

It does, the key was changed to space to prevent issues with trying to send the game to another monitor on startup (Windows Key + Shift + Left/Right) and it preventing autologin.

Also maybe it's possible to implement a check if the login fails (since the game continuously throws an error message) and cancel the auto login so it doesn't keep trying to login?

I haven't tested this particular issue myself yet (doing IRL stuff), but usually Autologin would just try to log into the character and if it doesn't exist, will just silently fail (because it has nothing to click) as opposed to give an error message.

xKiisa commented 2 weeks ago

Ohh i guess i didn't notice the change to space, i just tried it and it works :) But yes when the character is on another DC, it will keep spamming the login super fast

Aida-Enna commented 2 weeks ago

Uh oh, I'll take a look and see if I can do something about that. Thank you!

Aida-Enna commented 1 week ago

Should be resolved by https://github.com/Aida-Enna/XIVPlugins/commit/cd5f22741386013542618518d329b5d322f4890d, please open a new ticket (since it's a separate issue from the original one here) if not.

This update should also fix the original issue mentioned of the data center no longer being selectable after the plugin tries to login.