AidanHockey5
commented
2 years ago Hey there, Rene!
Yeah, no worries about the PCM bug. It was only a one-variable change, so no big deal.
And yes, you’re definitely correct that the YM2612 does leak a lot of audio through even when certain channels are supposed to be muted. You can often hear the operators whirring faintly in the background even when their key-on register is set to “off,” especially in some of my more MIDI-focused projects.
That being said, feel free to submit another PR! I’m interested in seeing what your contribution does.
Thanks again!
On Wed, Oct 27, 2021 at 1:27 PM Rene Daré @.***> wrote:
First, my apologies for the DAC bug introduced by the channel control enhancement. I've did a copy/paste of the DAC write command from another line in the same file and didn't notice you had a different variable to control DAC writes at that point in the code.
I've been playing with the chip channel pan control and i'm amazed by the noise that still can be heard even when you force the output for all 6 channels to either left or right. This happens only with the YM2612, not with the YM3438, likely because the crossover distortion caused the DAC output.
If you think this is a nice feature, let me know, I would be more than happy to push another merge request to add this feature. I've added an option to the main menu where you can toggle pan controls OFF/BOTH/LEFT/RIGHT for each channel. If this is turned OFF, it means we won't interfere and just let the song play as originally intended.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AidanHockey5/MegaBlaster2/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG7C36DC46PDWZYGCJNE4LUJBODLANCNFSM5G3HLCVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
First, my apologies for the PCM bug introduced by the channel control enhancement. I've did a copy/paste of the PCM write command from another line in the same file and didn't notice you had a different variable to control PCM writes at that point in the code.
I've been playing with the chip channel pan control and i'm amazed by the noise that still can be heard even when you force the output for all 6 channels to either left or right. This happens only with the YM2612, not with the YM3438, likely because the crossover distortion caused by the DAC.
If you think this is a nice feature, let me know, I would be more than happy to push another merge request to add this feature. I've added an option to the main menu where you can toggle pan controls OFF/BOTH/LEFT/RIGHT for each channel. If this is turned OFF, it means we won't interfere and just let the song play as originally intended.