search

AidenBeresford / FeGBA

Rust-based Game Boy Advance emulator written and maintained by TAMU students.
MIT License
0 stars 0 forks source link

Bounty: disassembler #3

Closed AidenBeresford closed 7 hours ago

AidenBeresford commented 1 week ago

Write disassembler function that returns an instruction from an opcode.

Each instruction is one point. You can only do one instruction at a time. When you choose an instruction you should write a reply to this issue so nobody else writes it before or after you.

List of available instructions

ARM

Branch and Branch Exchange Block Data Transfer Branch and Branch with Link Software Interrupt Undefined Single Data Transfer Single Data Swap Multiply and Multiply Long Halfword Data Transfer Register / Immediate PSR Transfer Data Processing

THUMB

Software Interrupt Unconditional Branch Conditional Branch Multiple Load / Store Long Branch with Link Add Offset to Stack Pointer Push / Pop Register Load / Store Halfword SP Relative Load / Store Load Address Load / Store with Immediate Offset Load / Store with Register Offset Load / Store Sign-Extended Byte / Halfword PC Relative Load Hi Register Operation / Branch Exchange ALU Operations Move / Compare / Add / Subtract Immediate Add / Subtract Move Shifted Register

AidenBeresford commented 1 week ago

2 adds is_branch_and_branch_exchange. Refer to this is a kind of style guide.

aybanda commented 5 days ago

@AidenBeresford Hey! I'd like to work on the ARM "Single Data Transfer" instruction for this bounty. Just claiming this one to avoid overlap.

aybanda commented 5 days ago

check this out #4 completes S̶i̶n̶g̶l̶e̶ D̶a̶t̶a̶ T̶r̶a̶n̶s̶f̶e̶r̶

AidenBeresford commented 5 days ago

@AidenBeresford Hey! I'd like to work on the ARM "Single Data Transfer" instruction for this bounty. Just claiming this one to avoid overlap.

Hey, sorry for the confusion, not sure if you found this with a scraper or something. This is an org project for TAMU students. The bounties are a point system within the group. Your code is fine but I'm not going to accept your PR because you're not a member of the development team. Have a good one.

AidenBeresford commented 5 days ago

Oh, I see. My issue comes up if you search bounty and go to issues. I'll change the naming so this doesn't happen again. Whoops!

aybanda commented 4 days ago

no probs @AidenBeresford

AidenBeresford commented 3 days ago

Branch and Branch with Link, Software Interrupt, and Undefined added by #5

AidenBeresford commented 2 days ago

Remaining ARM instruction disassemblies added by #6 .

AidenBeresford commented 1 day ago

THUMB instructions added by #7