search

AidenLYT / pe

0 stars 0 forks source link

Better suggestion for `better email validation` #11

Open AidenLYT opened 4 months ago

AidenLYT commented 4 months ago

image.png

Description

Since the TA ToolKit current targeted audience is for NUS CS2100 student, it would be better for TA to include @u.nus.edu emails only.

Idea

Instead of following IETF standards, can narrow down the scope to the NUS standard email.

This better helps TA to obtain the correct email to send important module informations. We would want to minimize the possibility of TA sending important school email to student's junk email or sort, causing the student to miss out on them.

nus-se-script commented 4 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Hi, Thank you for your kind feedback! We intentionally did not set overly strict email constraints because allowing such flexibility can in turn allow the user to use the software in different ways while overzealous rejection of inputs can annoy the user. For example, some TAs might wish to contact with their students via other domain names, for e.g, axelteo@comp.nus.edu.sg

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]