soc-pe-bot
commented
6 months ago Team's Response
Thank you for the feedback. However, the placement of this step as Extension 2a is intentional. This is because during step 2, TA Toolkit attempts to add the student to the list of students. However, during this process, a check realises that doing so would cause 2 contacts to have duplicate fields, thus causing step 2 to fail.
This triggers extension 2a, where an error message is displayed to the user. We have discussed this with Prof Damith during tutorial and he has mentioned that either placement is correct.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: A modified (to protect the identity of the team) MSS was posted in the course's forum: https://github.com/nus-cs2103-AY2324S2/forum/issues/976
Given the feedback posted by Prof Damith, a better approach to writing the MSS could be as follows:
- User enters the command to update a student's details
- TA Toolkit add and displays a success message along with the student's updated contact details
This in terms still fall under Documentation Bug as per the guideline given in the course website:
Such documentation has caused confusion and defer flagged as a bug.
^ Confusion by other reader of the MSS.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** [replace this with your reason] VeryLow severity is only given to cosmetic issue as per given by the course's guideline.
Description
Extension 2a should be extension 1b instead.
In the MSS, step 2 represents that TA Toolkit already pass the checks when user enters command to add a student and has added students to the list.
However, 2a states that new student already exists in the list of students, show error then resume back to step 1 (when step 1 has already passed).
Idea
Thus, 2a should be 1b where Toolkit immediately checks for field when user enters the command.