search

Aidoku / Aidoku

Free and open source manga reader for iOS and iPadOS
https://aidoku.app
GNU General Public License v3.0
2.61k stars 136 forks source link

Pillarbox sometimes not working #339

Open Jamerrone opened 1 year ago

Jamerrone commented 1 year ago

This is probably because of the latest commit making the border cropping work in the webtoon reader.

https://github.com/Aidoku/Aidoku/assets/16142485/29b8c689-5fa5-4181-88b3-505a72c242ee

Skittyblock commented 1 year ago

I can't reproduce this; it's working perfectly fine for me.

Jamerrone commented 1 year ago

Yeah, not sure what to tell you. As you can see in the video, it was clearly broken, but like I mentioned yesterday on discord it does not appear to break consistently. I will keep an eye on it, you can close it if you want. I can always contact you in discord about it.

Skittyblock commented 1 year ago

yeah I'll leave this open since the video clearly shows it's an issue, but let me know if it happens again or if you figure out how it might be triggered

Jamerrone commented 1 year ago

@Skittyblock i still don't have any clear steps on how to reproduce this issue. I was able to record a version of this bug that fixed itself by scrolling, so it definitely is an issue.

https://github.com/Aidoku/Aidoku/assets/16142485/8bda18f3-c57d-436e-83b8-8681c99ae20f

Jamerrone commented 1 year ago

@Skittyblock I'm now able to 100% reproduce this issue. It happens whenever I am in horizontal orientation and the Pillarbox orientation is set to "landscape". As long as I set it to "both" it works fine. So it's a minor bug, but it's an inconvenience because I read on a phone and I really need all the space I can get while reading vertically. I use it horizontally to get rid of the notch.

Skittyblock commented 1 year ago

I'm still unable to reproduce this.