search

Aidoku / Aidoku

Free and open source manga reader for iOS and iPadOS
https://aidoku.app
GNU General Public License v3.0
2.27k stars 121 forks source link

Pin/Passcode feature for Library Locking for those without faceID/fingerprint #358

Open Hidlsh opened 10 months ago

Hidlsh commented 10 months ago

Not only for those people who lack the FaceID/Fingerprint features on their devices, but also for use in environment(s) and/or conditions where the features don't work.

gabrielgasp commented 9 months ago

I wish we could lock the entire app, instead of limiting to history and libraries.

Skittyblock commented 9 months ago

That doesn't really make a whole lot of sense to me, and probably would be a pretty minor use case. You're better off jailbreaking for features like that, or setting up some type of focus mode or something.

Hidlsh commented 9 months ago

That doesn't really make a whole lot of sense to me, and probably would be a pretty minor use case. You're better off jailbreaking for features like that, or setting up some type of focus mode or something.

Is this in response to GabrielGasp's comment or my post? Either way, the implementation of App Locking and Pin/Passcode locking isn't new. Many apps have it. Also, most people don't go out of their way to set up focus modes/jailbreak their devices nowadays. Think of the times; people are on IOS 17 now. If anything, Pin/Passcode lock on libraries or categories is more than enough. Even in other areas (aside from phone unlock) of the IOS platform, it natively prompts for passcode entry when FaceID isn't available/can't be used. image It's rather an inconvenience to strictly have only FaceID locking. It also seems that Aidoku's "Lock Library" feature breaks with repetitive failure to provide proper faceID; it prompts the user to enter in their device's passcode (likewise to the picture above), but instead acts as if the action was canceled, allowing the user to simply press the Lock Icon on the top right within the selected category to unlock it.image Which also breaks the select the "Locked Categories" button in settings.

Skittyblock commented 9 months ago

I was responding to @GabrielGasp. The passcode fallback for Face ID definitely makes sense.

Hidlsh commented 9 months ago

I was responding to @GabrielGasp. The passcode fallback for Face ID definitely makes sense.

Ah alright. I just tested the passcode fallback again after a couple hours. It doesn't seem to work on Aidoku. Upon pressing "Enter Password", nothing happens; the password popup doesn't show, but the "Locked Categories" button works like normal again. I probably bugged it the first time lol

CEBATOR commented 1 month ago

I wish we could lock the entire app, instead of limiting to history and libraries.

iOS 18 got you covered ;)

Hidlsh commented 1 month ago

I wish we could lock the entire app, instead of limiting to history and libraries.

iOS 18 got you covered ;)

Finally 😂😂