search

Aietes / node-red-contrib-harmony

Node-RED integration for Harmony hub
MIT License
15 stars 18 forks source link

Error: Cannot find module 'autobind-decorator' #14

Closed bkanuka closed 5 years ago

bkanuka commented 5 years ago

This error appears in logs when installing the module through the node-red interface. I am also unable to search for Harmony hubs (which may or may not be related)

lespatots commented 5 years ago

I had the same. Try this install

npm install autobind-decorator

It Fixed it for me

Aietes commented 5 years ago

Thank you for reporting this! It seems to be is a dependency of the underlying library @harmonyhub. I'll check with @AirBorne04 and find a fix.

lespatots commented 5 years ago

npm install autobind-decorator fixes it, but I guess this should be part of the node install. In the meantime you could just record the dependency.

On 16 Aug 2018, at 08:30, Stefan notifications@github.com wrote:

Thank you for reporting this! It seems to be is a dependency of the underlying library @harmonyhub. I'll check with @AirBorne04 https://github.com/AirBorne04 and find a fix.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Aietes/node-red-contrib-harmony/issues/14#issuecomment-413440190, or mute the thread https://github.com/notifications/unsubscribe-auth/AK2Y3PxoouEZ3CoDf2QQ3Uz2CWs9a-YZks5uRRGagaJpZM4V-9S0.

Aietes commented 5 years ago

With regards to searching for Harmony hubs, since I also switched out the discover library, I think it's related to that. May I ask in what environment you run Node-RED? OS, version, in a docker container?

lespatots commented 5 years ago

I relise you didn't ask this to me but. I have two Harmony hubs and it only finds one. My Node-red is running on a raspberry pi without docker at present. I'm at the latest version 0.17.5?

I haven't been able to test any Harmony operations yet so I'm not sure whether setting the IP for the second hub is effective!

Aietes commented 5 years ago

I released a temporary fix for the missing library, version 1.2.1 now includes the autobind-decorator, until it's added as dependency to the underlying library.

Aietes commented 5 years ago

I moved to conversation re searching for Harmony hubs to a new issue #15. @lespatots currently the extension just takes the first Hub it finds. I'll opened an enhancement issue #16 to support multiple hubs. I actually have two myself :) Entering the IP of the second Hub manually will work though.

AirBorne04 commented 5 years ago

I fixed the dependency issue right away, should work now.

Aietes commented 5 years ago

Thanks to @AirBorne04 this is fixed, released version 1.2.2