AigeStudio / WheelPicker

Simple and fantastic wheel view in realistic effect for android.
Apache License 2.0
2.56k stars 510 forks source link

"wheel_item_space" have no affect #125

Open verybluebot opened 6 years ago

verybluebot commented 6 years ago

"wheel_item_space" have no effect. void setItemSpace(int space); method have effect either

xml:

        <com.aigestudio.wheelpicker.WheelPicker
            android:id="@+id/wheelPicker"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            app:wheel_item_space="20dp"/>

Java:

        WheelPicker wheelPicker = (WheelPicker) findViewById(R.id.wheelPicker);
        wheelPicker.setItemSpace(20);
        wheelPicker.setAtmospheric(true);
        wheelPicker.setData(testList);

help

verybluebot commented 6 years ago

Hi, Barbara Thanks for the response, for some reason cant see this message in the issue on git, never mind...

I tryed to play with these values:

setVisibleItemCount() setItemSpace()

how can I control this 'TextMaxHeight'?

in any case none of those worked. NOTE: I need the height of the wheel be not changed.

Thanks On Fri, Nov 10, 2017 at 1:00 AM, Barbara Gomes notifications@github.com wrote:

Try to play around with the height of the Wheel and the visible items.

The item height will be calculated in terms of those constrains, like written in the code:

mTextMaxHeight mVisibleItemCount + mItemSpace (mVisibleItemCount - 1)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AigeStudio/WheelPicker/issues/125#issuecomment-343320051, or mute the thread https://github.com/notifications/unsubscribe-auth/AR4EE0rpFp2V26ZrUf7xGPYcXH1Tqyguks5s04QFgaJpZM4QOE8x .

plrdev commented 6 years ago

ItemSpace doesn't seem to work for me either.

barbaragomes commented 6 years ago

@verybluebot Sorry, I deleted my response because after further analise I still have the same issue where ItemSpace makes no difference for me either.

I get the height I want by playing around with both methods:

setVisibleItemCount() setItemSpace()

Sorry again for that

verybluebot commented 6 years ago

for me those two do nothing :/

On Nov 13, 2017 20:29, "Barbara Gomes" notifications@github.com wrote:

@verybluebot https://github.com/verybluebot Sorry, I deleted my response because after further analise I still have the same issue where ItemSpace makes no difference for me either.

I get the height I want by playing around with both methods:

setVisibleItemCount() setItemSpace()

Sorry again for that

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AigeStudio/WheelPicker/issues/125#issuecomment-344012853, or mute the thread https://github.com/notifications/unsubscribe-auth/AR4EE0LUtIlVBfWWpj1Cfa9b2HY2nuEaks5s2IqZgaJpZM4QOE8x .