search

Aiky30 / djangocms-4-migration

BSD 3-Clause "New" or "Revised" License
5 stars 13 forks source link

import settings from django.conf #13

Closed Chilipp closed 9 months ago

Chilipp commented 9 months ago

the helpers.py module imports the settings module that might not be available unless it's on the PYTHONPATH. the better way is to import it from django.conf.

see https://docs.djangoproject.com/en/5.0/topics/settings/#using-settings-in-python-code

Chilipp commented 9 months ago

Can you please add an entry to the Changelog to inform others of the change when it's released?

sure! done with 6ecfedb @Aiky30

Chilipp commented 9 months ago

but it seems like you already implemented this fix in https://github.com/Aiky30/djangocms-4-migration/commit/51a3a7b1da3fde47b97ae4a05dbda4d8e71d5ccf, so shouldn't we close this PR?

Aiky30 commented 9 months ago

but it seems like you already implemented this fix in 51a3a7b, so shouldn't we close this PR?

Ah yes, sorry about that, I hadn't realised that I should have merged this first. My apologies for that.