AimplainLeo / osgocean

Automatically exported from code.google.com/p/osgocean
GNU Lesser General Public License v3.0
0 stars 0 forks source link

[REOPEN] reflectionVisible calculation broken #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
As I failed to figure out how to reopen issue 27 (is that even possible?)
I'm filing a new one... copying my last comment:

I see that you reverted the patch again - may I ask why? The problem I'm
seeing is
that in the shader you do

  if(osgOcean_EnableReflections)
  {
    env_color = texture2DProj( osgOcean_ReflectionMap,
distortGen(vVertex, N) );   
  }
  else
  {
    env_color = gl_LightSource[osgOcean_LightID].diffuse;   
  }

although you (correctly) skipped reflection culling in
OceanScene::preRenderCull() -
which causes random noise from the reflection texture unit to appear on the
surface
(I suppose this depends on the OpenGL implementation...).

Original issue reported on code.google.com by felix.nawothnig on 10 May 2010 at 11:14

GoogleCodeExporter commented 9 years ago
Felix,

Sorry I should have asked you to clarify the issue before reverting the fix. 

I've added it back in.

Kim.

Original comment by kcb...@googlemail.com on 12 May 2010 at 9:57