AionGermany / aion-germany

Aion Emulator
GNU General Public License v3.0
202 stars 184 forks source link

Skill Animation Issues Solved! #28

Closed ghost closed 6 years ago

ghost commented 6 years ago

I fixing it now its a small error :) in skill animations i forgot something in static_data adding now :)

FrozenKiller35 commented 6 years ago

Maybe :D 21:44:24.012 ERROR[main]: - Error at [line=1257, column=83158654]: unexpected element (uri:"", local:"skill_animation"). Expected elements are <{}ride>,

ghost commented 6 years ago

I Commit now! FrozenKiller The errors should be gone now!

FrozenKiller35 commented 6 years ago

dont know if you have seen it on other issue.

Nice but it won't work...

Skill.java:

if (skillSkin.getTemplate().getSkillGroup().equalsIgnoreCase(skillTemplate.getSkillGroup()) && skillSkin.getIsActive() == 1) {

we don't have skillTemplate.getSkillGroup() so it wont find any skin and sends 0 on attack

maybe i find some other problems too ^^

ghost commented 6 years ago

Ow i found it Frozen Will add it now!

FrozenKiller35 commented 6 years ago

Btw adding a new animation should be active true or ?

And when you add a new animation there should be a new skill icon on HUD ;)

Oh and nice work (works better then first one ) 👍

FrozenKiller35 commented 6 years ago

Small Bug https://prnt.sc/jtdjes Deactivate won't work it always jumps back to active when you click on it

Sure i'll check the new Push

ghost commented 6 years ago

1451

ghost commented 6 years ago

What it does now for you frozen?

FrozenKiller35 commented 6 years ago

Give me a sec ^^

FrozenKiller35 commented 6 years ago

1: Deactivate working 2: New skill Icon still missing when learn a new animation 3: If you have 1 animation in your list and you learn a new one the new one gets removed if you change the first to deactived 4: if you add a second skill animation it wont be saved in DB ;)

FrozenKiller35 commented 6 years ago

For point 3 and 4

ALTER TABLE player_skill_skins MODIFY COLUMN skin_id int(11) NOT NULL DEFAULT 0 AFTER player_id, DROP PRIMARY KEY, ADD PRIMARY KEY (player_id, skin_id);

For point 2 wrong action for new animations (should be 0) ;)

SkillAnimationAction some time it is possible that PacketSendUtility.sendPacket(owner, new SM_SKILL_ANIMATION(owner)); is send 2 times

PacketSendUtility.sendPacket(owner, new SM_SKILL_ANIMATION(owner)); should be removed from @Override public void act

and only sended by public boolean addSkillSkin(int skinId, int time) {

ghost commented 6 years ago

Ow yes indeed :) the sql!

ghost commented 6 years ago

2: New skill Icon still missing when learn a new animation --- is still missing? also i pushed a new fix for 1 of the skills it crashed the game because there was a wrong tag inside!

FrozenKiller35 commented 6 years ago

wait i'll show you ^^

FrozenKiller35 commented 6 years ago

SM_SKILL_ANIMATION

Case 0 is for learn and icon display on HUD but you only use Case 1

and Case 0 should be without the for () it always should send only 1 skin on learn ;)

ghost commented 6 years ago

I will take a look at the file! and see what i can do i

FrozenKiller35 commented 6 years ago

I can do it ;)

FrozenKiller35 commented 6 years ago

@Onyenofficial I still remember him (http://forum.ragezone.com/f587/release-aion-lightning-v4-9x-1105747/#post8650044) but THX

ghost commented 6 years ago

Lol shut-up Ione stupid kid You and mhmd stole my stuff and released it on internet hacked my email + posted stupid stuff about me everywhere on internet i never leaked anything thats was not free! i just try to help people! like always but i dont care what they say i just want to help where i can ! you guys betrayd me! after all i did for mhmd! but bye Onyenofficial i dont gona talk with you anymore ! I have not blocked you for nothing !

FrozenKiller35 commented 6 years ago

https://image.prntscr.com/image/1SdhBHjkRj_cNlGSxt7UfQ.png

ghost commented 6 years ago

Oow now i understand Frozenkiller never thought about that :) i will fix it and than commit back!

FrozenKiller35 commented 6 years ago

already fixed ;)

ghost commented 6 years ago

Cool What did you do :) frozen? to fix it haha

ghost commented 6 years ago

Lol i already removed that src after he kicked me from team that event engine is free on internet :D even frozenkiller knows that eventengine its very old i am not even using it on private server so please go away kid :P let us work with your *** :D getting tired of you always following me and its not yours gerard pays archsoft for it but oke nvm 🗡 my own people know thats iam no leecher scammer or leak anything all free on internet!

FrozenKiller35 commented 6 years ago

You can see it in a few min (just checking all ;))

@Onyenofficial Nothing to steal here our 5.8 is open for all ^^ but again THX ;)

ghost commented 6 years ago

Your faster than me hahaha!

FrozenKiller35 commented 6 years ago

Updates / Fixes online ^^

@ghostfur @Onyenofficial Are you talking about Aion 4.5 FFA ? Oh and time to say GN for me ^^

ghost commented 6 years ago

Yes i gona sleep to GN :P Yes frozen they using FFA System From Killer Aion-Core and EventEngine from f14shm4n very old one And i never leaked anything from them or anywhere! he is just a anoying kid try to pull me down! but i really dont care frozen ! they will learn one day what real devolping is ! i am just here to add missing content i take it from my own source alot different than where he is working on he using this src so he came here to look if there where updates :P probably he take event window now and put it in his src like usually! but i laugh now iam to old for this sh1t 💃 they are just some immature indo kids 🖌

ghost commented 6 years ago

Whahahahaha from your what? the emulator you stole from archsoft? and released on ragezone haha i never seen it but archsoft tolt me about it! that was really leaking! also you guys changed all author names :D and now you say i change? but i go to sleep because i cannot stand your face anymore :D Tomorrow i will commit more fixes Frozen! its getting late :D and its 100% not there source scripts i can proof but not needed !

ghost commented 6 years ago

You Can Close this :) Frozen Before he put more messengers!

ghost commented 6 years ago

I already have 6.2 so bye Ione! and this skill skin is not yours i worked 2 weeks on it lol in your dreams keep decompiling korean emulators have fun! i will proof my self! against german team you will see but i gona sleep now because getting tired!

ghost commented 6 years ago

If you do not stop annoying me then you have a big problem and I mean it seriously I'm not going to be involved anymore with people like you I'm here to help aion germany and that's all stop with your messages and stop making fake topics with my name I know that you are jealous because I am further in devolping than you but that does not mean that you have to follow me wherever I am I will prove myself against aion-germany and other people! i can even show them that i make scripts myself! also You not really know me Ione! i am not even know you haha! so wtf

PLEASE CLOSE THIS ISSUE ! :)

ghost commented 6 years ago

Sure Ione! whatever! all sources i released where free on reg70.tk/forum so someone was before me haha! i only put them on ragezone so not sure what you understand under leaker the only thing i know is that you get nice source from archsoft than release is on ragezone than remove it! thats what i think is more leaking than releasing a source that already was released and was free but its oke for me i really dont care anymore iam 30 years old so why i would do stupid things like you and mhmd ! you guys steal dreamaion source using it for own private server 👍 iam not even using my sources for private servers 💃 Number one rule in devolping never release your own source to others always keep it safe! but its okey people will notice soon anough who the real leaker is ! have a good live ione and leave me alone please soon i going to germany its only 10min with car than i will talk and eat some wiener schnitzel with frozen and Falke they will see who the real ghostfur is !