search

AirLabsTeam / react-native-aws-cognito-js

React Native AWS Cognito JS SDK
Other
134 stars 19 forks source link

Backporting for old version of RN. #24

Open bprymicz opened 6 years ago

bprymicz commented 6 years ago

This is a long shot, but I've taken over a project done in RN v .38 and I need to pull the auth to Cognito out of a native package an into a JS lib. I used your library to do this for Android, but unfortunately I'm getting the issue with not being able to find RCTBridgeModule.h in RNAWSCognito.h. And I'm hoping their might be a simple fix that won't require me to do a major upgrade refactor.

To reproduce my issue I did the following: react-native init sample --version 0.38.0 npm install react-native-aws-cognito-js react-native link react-native-aws-cognito-js react-native run-ios

Which fails with: ` /node_modules/react-native-aws-cognito-js/ios/RNAWSCognito.h:4:9: fatal error: 'React/RCTBridgeModule.h' file not found

import <React/RCTBridgeModule.h>

`

Mobile and RN development is not my wheelhouse, but I'm hoping there is some sort of xcode configuration or tricks I can do to get this working and avoid a major overhaul. Thanks in advance for any assistance.

jmparsons commented 6 years ago

It already has the RCTBridgeModule compatibility check: https://github.com/AirLabsTeam/react-native-aws-cognito-js/blob/master/ios/RNAWSCognito.h#L2

Have you tried npm link with a cloned copy and removing that line altogether?

bprymicz commented 6 years ago

Yea. I know it has the check, that's what has me so confused. I've tried changing to just #import "RCTBridgeModule.h" but no dice. I assume it's something with how to configure xcode or something, but it simply will not build. Again, this is even without any code actually using it. Simply the RN shell and installing it and linking it.