Aircoookie / Espalexa

Alexa voice control for ESP8266/ESP32 (including brightness and color!)
MIT License
542 stars 134 forks source link

Fix discovering with esp8266 version 2.4.0 #194

Closed robertwillian closed 1 year ago

robertwillian commented 2 years ago

This changes fix crashing when Alexa is discovering devices.

My environment: ESP8266 boards: 2.4.0 Arduino IDE: 1.8.9

RyanGJones commented 1 year ago

Hey guys just spent a long time trying to get a tutorial working using an esp8266 board using this library to interact with alexa. I stumbled on these changes and when I added them it things finally worked. Perhaps this PR should be accepted?

Aircoookie commented 1 year ago

Agreed. While this does increase utilized memory, the way flash strings were used here can actually cause unaligned reads - merged.