search

Aircoookie / Espalexa

Alexa voice control for ESP8266/ESP32 (including brightness and color!)
MIT License
530 stars 135 forks source link

Espalexa does not need UPnP enabled for discovery #45

Open eos1d3 opened 5 years ago

eos1d3 commented 5 years ago

Tested with ESP32 and ESP-8266, with UPnP disabled for more than 20 times, none of them needs it to be enabled for discovery.

I really suggest removing "Espalexa might need to have UPnP enabled for discovery to work" in readme.md as UPnP adds more risk to security.

Aircoookie commented 5 years ago

Thank you, I will remove the notice. I was assuming it was required due to the Upnp:rootdevice device type in the SSDP discovery, but it is great news it's not actually needed, since I know it might cause security issues.

eos1d3 commented 5 years ago

Confirmed that UPnP is not required at all with ESP8266 for a lot of tests.

ESP32 is still not working for most of the time. But when it can be discovered, no UPnP is required too.

eos1d3 commented 5 years ago

With version 2.3.3, UPnP is also not needed at all. The notice can be safely removed.

Aircoookie commented 5 years ago

Good to hear! Notice will be removed with the next commit!