Aircoookie / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi!
https://kno.wled.ge
MIT License
14.63k stars 3.14k forks source link

Receiving adalight over serial crashes ESP 8266 and 32 #2618

Closed apophisnow closed 11 months ago

apophisnow commented 2 years ago

What happened?

Adalight over serial causes boards to crash.

To Reproduce Bug

To replicate, use LedFX to send adalight data over a serial connection to ESP 8266 or ESP 32 board. Board will crash and reboot after a short period of time. Baud rate has no impact. Multiple boards were tried.

Expected Behavior

Serial data should not cause board crashes.

Install Method

Binary from WLED.me

What version of WLED?

0.13.1

Which microcontroller/board are you seeing the problem on?

ESP8266, ESP32

Relevant log/trace output

No response

Anything else?

Using https://github.com/dmadison/Adalight-FastLED/blob/master/Arduino/LEDstream_FastLED/LEDstream_FastLED.ino I have no issues with boards crashing when receiving data from LedFX, but no luck when running WLED.

Adalight confirmed working on build 0.13.0b6 but is broken in latest build 0.13.1

Code of Conduct

Aircoookie commented 2 years ago

Thank you for reporting this! How many LEDs are you sending via Adalight?

apophisnow commented 2 years ago

I was testing with 22, but I don't think the count is part of the issue necessarily.

On Mon, Apr 4, 2022, 00:46 Christian Schwinne @.***> wrote:

Thank you for reporting this! How many LEDs are you sending via Adalight?

— Reply to this email directly, view it on GitHub https://github.com/Aircoookie/WLED/issues/2618#issuecomment-1087224262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJPIRWADPO4OQ3UM5CCAWDVDKM4TANCNFSM5SN6IIDA . You are receiving this because you authored the thread.Message ID: @.***>

Bene2103 commented 2 years ago

I experienced this behaviour too. But i downgraded to 0.13.0b6.

I also use Adalight protocol but with boblight. In my setup i have 220 LED's.

Thanks for your support!

sh00bx commented 2 years ago

Same here on 0.13.1 release. Already setting custom baud rate reliably crashes my ESP32s, unlike on ESP8266. Manually setting baud rate on 0.13.0b6 code not affected

might be #2517 related

sh00bx commented 2 years ago

I've created a hacky workaround for this issue on latest, making these changes:

See sh00bx-adalight-workaround

No more crashes with these modifications on 0.13.2a0 but to my surprise this did not also resolve another issue I have with adalight on serial, glitches in conjunction with wifi. But I'll open a separate issue on that.

blazoncek commented 11 months ago

If the issue persists in 0.14.0-b6 or later please reopen the issue.

AZDane commented 11 months ago

I see this behavior in 14.0b6. Using ESP32.

d3d9 commented 3 months ago

Can this be reopened as it still occurred on v0.14.0-b6 in October and for me just now on v0.14.4?

I am using an ESP 8266 with 32 pixels and previously used DDP over wifi from LedFx. Now I wanted to try adalight/serial.
This stops working after 1 or 2 seconds. Using one of the diagnostic LedFx effects like Metro or Pixels I could avoid the crash, but switching to something that lights up more pixels in different ways causes the crash almost instantly.
Though I'm not sure if crash is the right term. The WLED uptime doesn't get reset. It just doesn't react to further serial input at all until WLED is restarted. Which further details can I provide?