Aircoookie / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi!
https://kno.wled.ge
MIT License
15.1k stars 3.27k forks source link

Soap Effect Malfunctions if there are Gaps in LED Matrix #4140

Open jayceegee87 opened 2 months ago

jayceegee87 commented 2 months ago

What happened?

The soap effect malfunctions and occupies on a small subset of pixels when custom led map contains gaps between each row. The image below shows the difference between "soap" and a similar effect ("hiphotic") on a custom 21x15 led map. The majority of pixels for the soap effect are not illuminated and do not logically align to the ledmap file.

image

Note: the pixel maps used below reflect an earlier 17x13 configuration that is simpler for the purposes of the bug report.

To Reproduce Bug

Configure a 2d matrix that contains gaps between rows and activate the soap effect. The issue was replicated regardless of whether the 2d matrix was configured via manually via the app UI (i.e. using x and Y offsets to separate each strip as if they're separate "panels" with a height of 1 pixel) or via a an ledmap file (see screenshot below). All other effects appear to perform as expected.

image

If you remove the gaps by reconfiguring it from a 17x13 grid to a 17x7 grid, the soap effect appears as intended. However, this configuration distorts many other effects because it no longer reflects the vertical distribution of pixels that fill my circular light fixture.

image

Expected Behavior

I expected the effect to occupy all relevant pixels in the matrix.

Install Method

Binary from WLED.me

What version of WLED?

WLED v0.14.4 "Hoshi"

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

I've provided slightly more detail in an r/wled post about the issue when I checked to see if this was a known issue/limitation of the soap effect prior to reporting the bug.

Additional detail regarding my project is available via another r/wled post, however some details regarding the configuration are no longer up to date as I've encountered problems with my original plan.

Also, thank you.

Code of Conduct

blazoncek commented 2 months ago

Not just Soap, many other effects do the same with missing pixels. Fixing this will require additional RAM.