FX improvements and cleanup

[DedeHai]

This has been on my todo list for a long time, finally done. It adds some new functionality to 2D FX (blurring / smearing / palette support) and saves on code size (merged 1D FX) Note: Polar Lights is now slightly different as no palette matches the original effect palette

• Waving Cell: Improved with higher temporal resolution (smoother at lower speeds) and added additional mode setting and optional blurring

• Merged puddles and puddlepeak

• Merged Gravcenter, Gravcentric, Gravfreq and Gravimeter (saves 1.2k of flash)

• Merged meteor and meteor smooth

• Renamed police_base into mode_two_dots as that was just an alias

• Changed default of Palette effect: Animate rotation is now unchecked by default (it looks weird and confusing in 1D as a default)

• Added or enhanced blurring of

  • DNA
  • DNA Spiral
  • Drift
  • Drift Rose
  • Crazy Bees
  • Ripple
  • Colored Bursts
  • Frizzles
  • Lissajous
  • Sindots
  • Spaceships

• Added palette support to

  • Crazy Bees
  • Polar Lights
  • Drift Rose

• Some code cleanup (removed unused / commented stuff)

• Moved dev info for AR to the top so ist easier to find as a reference, also added link to KB there

[blazoncek]

@ewoudwijma @netmindz would you care to take a look as some effects were created by you.

• Changed default of Palette effect: Animate rotation is now unchecked by default (it looks weird and confusing in 1D as a default)

This will need to be checked with @triplewhy

[DedeHai]

I did not consider backward compatibility to be so important but you are right, will revert default behaviour back to what it was before. edit: should meteor_smooth be kept as an alias or is removing it ok?

[blazoncek]

should meteor_smooth be kept as an alias or is removing it ok

As we removed some effects in 0.13 and then again in 0.14 I think we can do that again in favour of the possibility to finally merge in PS effects. I would really like to see those (at least 2D) in.

[netmindz]

@ewoudwijma @netmindz would you care to take a look as some effects were created by you.

• Changed default of Palette effect: Animate rotation is now unchecked by default (it looks weird and confusing in 1D as a default)

This will need to be checked with @TripleWhy

I don't think any of those were added by me, but I can try and take a look at this PR in the next few days

[DedeHai]

last two commits (pal0 override and palette gradient for scrolling text) are just suggestions for review/comment.

[DedeHai]

This is now a little better but still does not cover HTTP API.

a little hint which function handles this?

[blazoncek]

a little hint which function handles this?

set.cpp ; handleSet()

[DedeHai]

handleSet() calls seg.setMode() which takes care of setting the default palette. what am I missing?

[blazoncek]

what am I missing?

Then you are all set. I do not know every line of code from the top of my head, but I do now a few relations that may be hidden.

[blazoncek]

Ah, disregard. 🤦

[DedeHai]

maybe cherry-pick the latest commit before 0.15 release?(https://github.com/Aircoookie/WLED/pull/4145/commits/6a269447f6438e53835545b51d4ce2e3ebee5b15 )

[blazoncek]

maybe cherry-pick the latest commit before 0.15 release?(6a26944 )

As this is a bugfix you can edit and push 0_15 branch directly. Just don't do it like you did for #3877 😄 use AC repo.