search

Aircoookie / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi!
https://kno.wled.ge
MIT License
15.04k stars 3.25k forks source link

Usermod F-string hygiene #4223

Closed willmmiles closed 4 weeks ago

willmmiles commented 4 weeks ago

Another missing remnant of the end-oappend work: migrating usermods to use F() instead of F_STR() so as to pass the FlashStringHelper type along to the print() layer. Usermods calling oappend(F_STR("") on ESP8266 will crash without the shim in #4222. This could be considered an alternative fix: correct the source, rather than provide a workaround at a runtime cost.

blazoncek commented 4 weeks ago

IMO both are good. The other one will prevent misuse in the future.

softhack007 commented 4 weeks ago

Thanks 👍 should be merged as it's a critical bugfix for 8266.