In 0.15.0-b7 and -b6, the "release" is always returned as `1`

Moustachauve commented 1 week ago

What happened?

Release is always 1 instead of ESP32 or whatever should be needed.

To Reproduce Bug

1) Download the release version from Github for 0.15.0-b7-ESP32.bin 2) flash it to an esp32 3) go to [ipAddress]/json/info 4) notice the release field is always 1

Expected Behavior

the release field should be ESP32.

Install Method

Binary from WLED.me

What version of WLED?

WLED 0.15.0-b7 1 (ESP32-D0WDQ5 build 2410270)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Moustachauve commented 1 week ago

I didn't try just manually building the release on my side, maybe they just need to be rebuilt with the correct flags in platformIO? Maybe the person that built them had an override or something.

softhack007 commented 1 week ago

Hi @Moustachauve,

I've just tried it, and indeed the firmware WLED_0.15.0-b7_ESP32.bin shows a wrong release string:

{
    "ver": "0.15.0-b7",
    "vid": 2410270,
    "cn": "Kōsen",
    "release": "1",

While WLED_0.15.0-b7_ESP32_WROVER.bin has the correct info

{
    "ver": "0.15.0-b7",
    "vid": 2410270,
    "cn": "Kōsen",
    "release": "ESP32_WROVER",

Moustachauve commented 1 week ago

Oh! Some of them work. I tried with ESP8266 binary and it was also showing a 1, so not all of them are incorect.

Aircoookie / WLED