Replaced single palette cases with an array to consolidate code

Aircoookie / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi!

https://kno.wled.ge

MIT License

15.04k stars 3.25k forks source link

Replaced single palette cases with an array to consolidate code #4270

Open DedeHai opened 1 week ago

DedeHai commented 1 week ago

all palettes are now defined in palettes.h
access to fastled palettes as an array to remove the switch cases
palette creation in json.cpp in a loop instead of repeated calls to save some flash (about 300 bytes)

DedeHai commented 1 week ago

there are a few other functions used from fastled: CRGB and 8-bit math functions for example. I am not sure there is much benefit from copying all those functions instead of using the library but I may take a closer look once all the PRs are merged.

blazoncek commented 1 week ago

qadd8(), sin8/sin16(), random8/random16() I think you touched all of them at some point. Other that are used are overloaded operators (i.e. + etc) which operate on struct CRGB (which you also touched).

I am not saying that it is necessary to replace the library, I am just thinking out loud about possibility to replace library since you already ventured into those waters by replacing some of the functionality of FastLED.