search

Aircoookie / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi!
https://kno.wled.ge
MIT License
15.04k stars 3.25k forks source link

0.15.0-rc1 #4287

Open netmindz opened 6 days ago

willmmiles commented 6 days ago

I recommend prioritizing a fix for #4260 before moving to RC, especially since it pertains to version identity data.

netmindz commented 6 days ago

Thank you @willmmiles for bringing https://github.com/Aircoookie/WLED/issues/4260 to my attention, yes that will need to be fixed before the Release Candidate

blazoncek commented 6 days ago

IMO #4260 was a build glitch. IDK how it happened (it shouldn't). The easiest way to check is build, upload and verify.

softhack007 commented 5 days ago

I'm seeing a few new bug reports related to the LEDs setting UI. Maybe we should analyze them before going to RC.

Plus this one that seems to affect all S2 users

blazoncek commented 5 days ago

Disabling brightness limiter requires additional changes before saving #4277

I could not reproduce. Perhaps requesting browser logs is in order.

Ports >3 lose GPIO, Length and mA/LED settings upon save #4280

May be related to limiter. I could not reproduce. Same submitter as previous. Perhaps issue on his/her setup.

Crashes when leds length is 3 #4120

This one should be easy for anyone to reproduce if true. I could not.

OTA Updating ESP32-S2 from 0.15.0-b4 fails #4241

I have 3 S2 units in production use (>400 pixels, multirelay, PIR sensor, temprature usermods, MQTT), all updated OTA regularly with no issues. Same with @DedeHai . @willmmiles did see issues though. Probably device FS issue.

I am sure that in all cases debug log and crash dumps with exception decoder are needed to diagnose. None were provided since submitting.

k7bbr commented 5 days ago

Disabling brightness limiter requires additional changes before saving

4277 https://github.com/Aircoookie/WLED/issues/4277

I could not reproduce. Perhaps requesting browser logs is in order.

Ports >3 lose GPIO, Length and mA/LED settings upon save #4280 https://github.com/Aircoookie/WLED/issues/4280

May be related to limiter. I could not reproduce. Same submitter as previous. Perhaps issue on his/her setup.

I easily reproduced this issue when flashing a new, out-of-the box WT32. Unable to set pins or pixel type. The module was completely bricked for 0.15.x even after USB flashing to 0.14.4 and the flashing again to 0.15.x. not just a single user.

Crashes when leds length is 3 #4120 https://github.com/Aircoookie/WLED/issues/4120

This one should be easy for anyone to reproduce if true. I could not.

OTA Updating ESP32-S2 from 0.15.0-b4 fails #4241 https://github.com/Aircoookie/WLED/issues/4241

I have 3 S2 units in production use (>400 pixels, multirelay, PIR sensor, temprature usermods, MQTT), all updated OTA regularly with no issues. Same with @DedeHai https://github.com/DedeHai . @willmmiles https://github.com/willmmiles did see issues though. Probably device FS issue.

I am sure that in all cases debug log and crash dumps with exception decoder are needed to diagnose. None were provided since submitting.

— Reply to this email directly, view it on GitHub https://github.com/Aircoookie/WLED/pull/4287#issuecomment-2480741559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGGPSXCZAGYGMPMTVADGIXL2A6KDNAVCNFSM6AAAAABR37JB7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQG42DCNJVHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

willmmiles commented 5 days ago

Re #4277 and #4280: I've seen something in this vein (LED settings not saving) on my test setup. I was having a bunch of unrelated connectivity issues, so I just wrote it off at the time. Trying to reproduce it now.

Re #4241: I'm 95% confident that what's happening is heap starvation of some kind. S2s have practically as little RAM as 8266es, but all the code (including the platform!) treats them like the bigger ESP32s. I could also reliably trigger a heap exhaustion crash by messing up the upload parameters so it didn't get handed to Uploader properly. I'm going to probe to see if there's something I can do in AsyncWebServer to trap that case and not crash, at least. (Doesn't answer why ArduinoOTA and other non-webserver uploads also fail for some users, though.)

netmindz commented 5 days ago

Ok, it wasn't my original intention with this PR, but are we ok with adopting this as the issue where we track items that must be resolved before the RC?

blazoncek commented 5 days ago

@k7bbr please provide crash dumps or debug logs in respective issues, not here.

@willmmiles try ArduinoOTA for S2. Uses different route.