AirenSoft / OvenMediaEngine

OvenMediaEngine (OME) is a Sub-Second Latency Live Streaming Server with Large-Scale and High-Definition. #WebRTC #LLHLS
https://airensoft.com/ome.html
GNU Affero General Public License v3.0
2.54k stars 1.06k forks source link

Admission Webhook not called when forcefully closing RTMP client #1570

Closed bartvp1 closed 1 month ago

bartvp1 commented 6 months ago

Describe the bug The admission webhook for closing RTMP streams is not called when a it closes unexpectedly

To Reproduce Steps to reproduce the behavior:

  1. Set up OME with RTMP ingress & admission webhooks
  2. Start a RTMP stream using Larix
  3. Disable the internet connection on the broadcasting device

Expected behavior The admission webhook should be called with the information of the cancelled RTMP stream

Server

getroot commented 6 months ago

OME may not be aware that the RTMP session has been disconnected. If TCP keepalive is working, OME will notice the tcp connection termination after several tens of seconds. Admission webhooks aren't being called even though the log shows the stream has been deleted?

bartvp1 commented 6 months ago

The logs don't show anything in regard to the disconnected RTMP client.

bartvp1 commented 4 months ago

Any updates on this issue?

I need this feature because I need to keep track of active streams in a separate, realtime database. I investigated whether syncing the redis server (origin map store) would fix this issue, but OME keeps sending SET and EXPIRE commands to the Redis server, despite not receiving any new frames. This results in streams still remaining while they are not.

getroot commented 4 months ago

The server doesn't notice that the TCP connection between the RTMP client and the server has been lost. You might want to look into setting up TCP Keepalive on the server.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.