Multi-threading issue in MediaRouteStream

AirenSoft / OvenMediaEngine

OvenMediaEngine (OME) is a Sub-Second Latency Live Streaming Server with Large-Scale and High-Definition. #WebRTC #LLHLS

https://airensoft.com/ome.html

GNU Affero General Public License v3.0

2.61k stars 1.06k forks source link

Multi-threading issue in MediaRouteStream #55

Closed rubu closed 4 years ago

rubu commented 5 years ago

Just patched everything to run OvenMediaEngine on MacOS - and it segfaults with a trivial RTMP provider setup.

The crash happens since _queue in MediaRouteStream is touched without a mutex in Push/Pop methods. Adding a mutex for the queue access works, but I am actually quite amazed that this has not been reported by anyone else.

Keukhan commented 5 years ago

Hello, rubu.

Thank you for your report. The modified code will be reflected in the next release.

Sorry for the late reply. Hope you're having a great day.

rubu commented 5 years ago

Thanks, I'll live my local branch for now and when you have the next release will try to merge stuff together.

getroot commented 4 years ago

This issue has been closed since it has been inactive for quite some time.If you need this issue to be discussed again, please feel free to reopen it.