Open aweinert-MIT opened 2 years ago
The MATLAB mex function, run_dynamics_fast is used by multiple repositories, including em-model-manned-bayes to simulate aircraft trajectories with a 6DOF physics model. There are various #define statements that are unguarded.
run_dynamics_fast
em-model-manned-bayes
#define
Add #define guards to prevent multiple inclusions.
#define guards are a good best practice and should be implemented.
Recommend addressing issue #10 for the use const variables before addressing this issue.
const
While the contributing guidelines does not define a style guide for C++, we currently recommend the Google C++ Style Guide for this issue.
Relation
The MATLAB mex function,
run_dynamics_fastis used by multiple repositories, includingem-model-manned-bayesto simulate aircraft trajectories with a 6DOF physics model. There are various#definestatements that are unguarded.Description
Add
#defineguards to prevent multiple inclusions.Alternatives
#defineguards are a good best practice and should be implemented.Additional
Recommend addressing issue #10 for the use
constvariables before addressing this issue.While the contributing guidelines does not define a style guide for C++, we currently recommend the Google C++ Style Guide for this issue.