Airthings / wave-reader

MIT License
50 stars 18 forks source link

Python 3? #8

Closed buldre closed 4 years ago

buldre commented 4 years ago

Will it work in Python 3?

orjangj commented 4 years ago

I haven't tested it with Python3, but I think it should work as long as you modify the print statements to be Python3 compliant. E.g. print "something" to print("something").

buldre commented 4 years ago

Thanks! Good to know before I buy and try!

  1. feb. 2020 kl. 12:49 skrev orjangj notifications@github.com:

 I haven't tested it with Python3, but I think it should work as long as you modify the print statements to be Python3 compliant. E.g. print "something" to print("something").

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

orjangj commented 4 years ago

Just a note:

If you plan on buying a 2nd generation Wave product, then read_wave.py will not work. However, I can upload a script for that product if you'd like.

buldre commented 4 years ago

Hi,

Yes, please! And thanks!

Will you be able to test against a 2nd gen Wave? And I assume you use Python 3 now?

  1. feb. 2020 kl. 14:52 skrev orjangj notifications@github.com:

 Just a note:

If you plan on buying a 2nd generation Wave product, then read_wave.py will not work. However, I can upload a script for that product if you'd like.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

orjangj commented 4 years ago

I've uploaded read_wave2.py for reading sensor data from a 2nd Generation Wave. I've also modified the scripts to be both py2 and py3 compatible. See updated readme.

orjangj commented 4 years ago

I'll close this issue now that the repo provides the sufficient support for interfacing both 1st and 2nd Gen Wave devices. If you discover any issues, then don't hesitate to create a new issue.

buldre commented 4 years ago

Tusen takk!

Sendt fra min iPhone

  1. feb. 2020 kl. 11:28 skrev orjangj notifications@github.com:

 I'll close this issue now that the repo provides the sufficient support for interfacing both 1st and 2nd Gen Wave devices. If you discover any issues, then don't hesitate to create a new issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.