search

AitorDB / home-assistant-sun-card

Home assistant sun card based on Google weather design
MIT License
407 stars 184 forks source link

Added total hours of sun and remaining sun hours #36

Closed mttn3773 closed 3 years ago

mttn3773 commented 3 years ago

im not sure that localization is accurate (just put lines in the google translator).

AitorDB commented 3 years ago

Thanks for the PR! I can see that there's many code styles changes (adding semicolon, double quotes, etc.), would you mind change those back?

AitorDB commented 3 years ago

I'm thinking, that for localization, it's probably better to just add the words in English rather than translator. In my experience, the traslations are not the most accurate, so probably the best option is to leave that part for people that speak the language and don't mind to open a PR/issue with the translations