AitorDB / home-assistant-sun-card

Home assistant sun card based on Google weather design
MIT License
407 stars 184 forks source link

Add hebrew language support #44

Closed baget closed 3 years ago

baget commented 3 years ago

Adding Hebrew localization

AitorDB commented 3 years ago

Thanks for the PR! Would you mind to add some of the new texts? Here's an updated example in English. It will be awesome if you could also fix the indentation (2 spaces) and the line at the end

{
  "Azimuth": "Azimuth",
  "Dawn": "Dawn",
  "Dusk": "Dusk",
  "Elevation": "Elevation",
  "Noon": "Solar noon",
  "Sunrise": "Sunrise",
  "Sunset": "Sunset",
  "errors": {
    "SunIntegrationNotFound": "Sun integration not found"
  }
}
baget commented 3 years ago

Thanks for the PR! Would you mind to add some of the new texts? Here's an updated example in English. It will be awesome if you could also fix the indentation (2 spaces) and the line at the end

{
  "Azimuth": "Azimuth",
  "Dawn": "Dawn",
  "Dusk": "Dusk",
  "Elevation": "Elevation",
  "Noon": "Solar noon",
  "Sunrise": "Sunrise",
  "Sunset": "Sunset",
  "errors": {
    "SunIntegrationNotFound": "Sun integration not found"
  }
}

Sure, no problem, WIP

idoaflalo commented 3 years ago

Looks pretty good!

AitorDB commented 3 years ago

Sorry for asking for more changes, but the indentation is not 2 spaces and there's an issue with the last line, could you fix that?

baget commented 3 years ago

Sorry for asking for more changes, but the indentation is not 2 spaces and there's an issue with the last line, could you fix that?

so what is the indentation ??

baget commented 3 years ago

I hope it is ok now.