search

Aiue / AQT

Quest Tracking Addon for World of Warcraft
Other
2 stars 1 forks source link

The radio options on the "Output" tab are not working properly. #73

Open chkmyid opened 5 years ago

chkmyid commented 5 years ago

These settings are only shown with options, but they don't actually work. /say channel only shows "Announce Progress". and the "Announce Progress" option is printed in multiple lines, depending on the number of objectives, including the quest title. This makes the chat channel very messy. Like any other addon(QuestAnnounce3 or QuestCrier, etc. that works in the Classic.), I would like to have an output in one line only in the form of "Quest Title: Objectives(Index) #/#" If you thought of it simply as a report function, I misunderstood it, but most users will use this option with the attention of what I said. Do you think I'm right?

Aiue commented 5 years ago

These are different things. I should probably rename the output tab to better reflect this. It sort of ended up that way because that's what LibSink names its own AceConfig group.

The output tab is basically just sending quest updates to the place specified, similar to how the default UI send them to UIErrorsFrame.

I could look into having the manual announce be less.. spammy.

Aiue commented 5 years ago

Optionally, I could implement a click-command for objectives as well, as I've been meaning to do for quite a while, that would only send information about a single objective, rather than all of them.

Aiue commented 5 years ago

I'll leave this open until I can figure out a better way to describe the "Output" config group.

chkmyid commented 5 years ago

version 1.1.7

The "Announce Progress" menu does not output to the channel set in "Output". If selected for the "None" or "Channels" entry, it is still output to the /say channel, other than the following error message appears: SendChatMessage(): Chat message must be UTF-8 text (x1)

Aiue commented 5 years ago

The output tab, still unredescribed, is still not intended to set the target for "Announce Progress". "Announce Progress" simply chooses a channel based on your grouped status, raid, party, or say. I suppose I could change it to send it to the chat input box instead, in case one wants to use a channel other than these.

I don't know what it might be trying to send that is not UTF-8. It's possible the API somehow provides something that is not. I will investigate, but it might take a bit to get to the bottom of it.

Aiue commented 5 years ago

Some info on the quest name and objective text may help in figuring out what's causing it to fail to send. I'm gonna see if I can find a way to sanitize the string of any non-utf-8 characters before calling SendChatMessage(), though, so such information may be redundant at this point.

Aiue commented 5 years ago

This should be squished now, but leaving it open in case I missed something somewhere.