Open links in default browser on electron edition of Kahla.

AiursoftWeb / Kahla.App

Kahla is a cross-platform business messaging app.

https://www.kahla.app

MIT License

415 stars 85 forks source link

Closed Anduin2017 closed 5 years ago

Anduin2017 commented 5 years ago

Open links in default browser on electron edition of Kahla.

When sending links in Kahla and click it, the page was opened in Kahla. I guess it was not valid.

The link shall be open in default browser.

Anduin2017 commented 5 years ago

@hv0905 I was about to close this, but another error occurs

Repro steps:

Screenshot (187)

Just install and double click the app.

hv0905 commented 5 years ago

Oh...It seens there are some problem in package-lock.json.. I will fix it later.

Anduin2017 commented 5 years ago

It seems that @xxyzz has another solution now. He told me that his solution works better and don't require any other 3rd-party libraries.

I will ask him later.

Anduin2017 commented 5 years ago

His solution is similar with this one

hv0905 commented 5 years ago

Yeah using ngx-electron to open shell might be a better solution. Nice.