search

AiursoftWeb / Kahla.App

Kahla is a cross-platform business messaging app.
https://www.kahla.app
MIT License
415 stars 85 forks source link

Possible to loose a message during sending messages. #710

Closed Anduin2017 closed 4 years ago

Anduin2017 commented 5 years ago

[//]: <Don't delete any header! Please fill out the form or your bug report will not be considered!>

Environment

How to repro

Currently, I do not know how to repro. But I have reproed this several times.

image

Expected situation

I expect that no matter what happened and what I send, no message will disappear.

Other information

Nothing.

Anduin2017 commented 5 years ago

I guess this issue is possible with Stargate. For multiple events, Stargate may lose one event so the client is always in sending status.

But that is only a possible reason.

Wenfengcheng commented 5 years ago

Repro step: When the previous message is in the sending state, sent the next message, and then the two message will be sent successfully, but the previous message will be removed.

hv0905 commented 5 years ago

When the message is still in the sending state, it is just a temp message and will be removed when the next stargate event comes. So if the stargate lost any message event, the issue might happened.

Anduin2017 commented 5 years ago

While I couldn't find out why Stargate may lose message, can app-side changes make the temp message not just disappear or some other logic to judge if the message was sent?

hv0905 commented 4 years ago

Way to repro steady: 1.go to a very slow network (GFW dalay is enough). 2.open kahla, then go to a conversation. 3.refresh by pressing F5. 4.while the conversation shows again, quickly type and send any message.(before the yellow bar disappear) 5.You can see the message always in sending status.

hv0905 commented 4 years ago

It seems that the issue has been fixed.

Anduin2017 commented 4 years ago

Nice! We shall keep testing this for at least 7 days before we release it to production.